Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker github actions #6045

Merged
merged 1 commit into from
May 31, 2024

Conversation

kidder
Copy link
Member

@kidder kidder commented May 30, 2024

Proposed changes

The actions for building a docker container need to be updated

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the problem? And have you tested the new version?

@kidder
Copy link
Member Author

kidder commented May 30, 2024

It failed to deploy a container, with the following errors:

[Build and deploy](https://github.com/kidder/spectre/actions/runs/9271381958/job/25506598463#step:6:13169)
buildx failed with: ERROR: failed to solve: process "/bin/sh -c apt-get update -y     && apt-get install -y python3-pip python-is-python3     && pip3 --no-cache-dir install pybind11~=2.6.1     && pip3 --no-cache-dir install -r requirements.txt -r dev_requirements.txt     && rm requirements.txt dev_requirements.txt" did not complete successfully: exit code: 1

Build and deploy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/setup-qemu-action@v2, docker/setup-buildx-action@v2, docker/login-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

After updating, the actions, I am able to deploy a container

@nilsvu
Copy link
Member

nilsvu commented May 30, 2024

Ok great! What was the error in the pip install? I think I tried recently and it wanted to build wheels for h5py for some reason and failed, was that the error here too?

@kidder
Copy link
Member Author

kidder commented May 30, 2024

The only error message I could see was the one above... After I updated the actions I didn't get an error

@nilsdeppe nilsdeppe merged commit 466ad68 into sxs-collaboration:develop May 31, 2024
22 checks passed
@kidder kidder deleted the update_docker_actions branch June 4, 2024 13:30
@nilsvu nilsvu added the ci/cd Continuous integration & deployment label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants