Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress ElementId more #6046

Merged
merged 2 commits into from
May 30, 2024

Conversation

nilsdeppe
Copy link
Member

Proposed changes

I hadn't realized you could have IDs smaller than 96 bits with Charm++. I thought it always had to be exactly 96 bits. This saves us another 4 bytes in the ElementId of unused space.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@kidder kidder merged commit a5b473d into sxs-collaboration:develop May 30, 2024
22 checks passed
@nilsdeppe nilsdeppe deleted the compress_element_id branch August 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants