Clarify error in InitializeJ #6048
Conversation
| "alteration of the spherical mesh. This could be an indication that " | ||
| "there is an issue with the worldtube data, such as incorrect " | ||
| "computation of the spherical harmonic modes. If you are confident " | ||
| "the worldtube data is correct, then please use an alternative " | ||
| "initial data generator such as `InverseCubic`. If that fails, " | ||
| "please double check that your spherical harmonic modes are decaying " | ||
| "correctly with increasing (l,m).\nError: " |
There was a problem hiding this comment.
So this error happens because (physically) the conformal factor is too large and therefore the transformation needed is no longer well-defined. I'm not really sure how to best incorporate that since it's a bit technical and I don't know what to suggest in terms of options or in terms of data to keep the conformal factor reasonable.
I don't really think the part about incorrect computation of the spherical harmonic modes will be that useful to most people since they will likely get worldtube data from sources that do their spherical harmonic computation correctly. The part about decaying modes sounds good to keep though.
There was a problem hiding this comment.
I agree! I just rebased and squashed the removal of that part :) Thanks for the review!
nilsdeppe
force-pushed
the
clarify_initialize_j_error
branch
from
956f72b
to
eb6427c
Compare
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments