-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMR: do not enforce 2:1 balance in normal direction #6058
Conversation
@nilsvu here is the unfinished (and untested) branch for what you asked about |
@nilsvu this is now ready for review. It did not cause any problems when I ran the RandomAmr executables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for adding this.
@@ -133,6 +133,7 @@ Amr: | |||
Verbosity: Verbose | |||
Criteria: [] | |||
Policies: | |||
EnforceTwoToOneBalanceInNormalDirection: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe set all these options to false
? To me at least that's the expected behavior of AMR. Do we even have a use case for true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set them to true
to reproduce previous behavior. Until setting them to false
is more extensively tested, I'd rather keep them true
for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok Im just worried that this will remain true
and propagate to many input files and people will get unexpected behavior when trying AMR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in evolution problems we probably want it true. Geoffrey had issues if the grid size changed too much form one element to the next in the normal direction to the interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually what I'm trying to prevent as well, in a domain that has differently sized blocks. For example, think of the thermal noise problem with thin layers on top of a substrate. You want to h-refine the substrate multiple times in z-direction, but each layer stays at h-refinement level 0.
Anyway, we can merge the PR like this and just have to keep in mind to experiment with this option.
Proposed changes
Remove requirement that h-refinement must have 2:1 balance in the direction normal to faces.
Upgrade instructions
In input files that use AMR, you will need to add
EnforceTwoToOneBalanceInNormalDirection: true
to the list of PoliciesCode review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments