Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification for new contributors #6066

Merged

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Jun 6, 2024

This automation hasn't ever really worked because of security restrictions by GitHub. But this change should fix it, see here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

This hasn't ever really worked because of security restrictions
by GitHub. But this change should fix it, see here:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
@nilsvu nilsvu added bugfix ci/cd Continuous integration & deployment labels Jun 6, 2024
@nilsvu
Copy link
Member Author

nilsvu commented Jun 6, 2024

Actually I'm just merging this because there's no way to test this anyway and it has no other impact whatsoever

@nilsvu nilsvu merged commit 85ea322 into sxs-collaboration:develop Jun 6, 2024
19 checks passed
@nilsvu nilsvu deleted the fix_new_contributors_notification branch June 6, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix ci/cd Continuous integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant