Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defaults from TransformVolumeData.py #6071

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Jun 7, 2024

Instead, prompt the user for missing dataset names. This makes it more predictable and safer which datasets are read and written, and makes it easier to use the tool.

I've been using this tool to compute Christoffel derivs and spatial Ricci tensor in initial data to find horizons:

spectre transform-vol BbhVolume* -k spectre.NumericalAlgorithms.LinearOperators.partial_derivative
# then select 'SpatialChristoffelSecondKind' when prompted

spectre transform-vol BbhVolume* -k spectre.PointwiseFunctions.GeneralRelativity.ricci_tensor
# also select the dataset names when prompted

spectre bbh find-horizon BbhVolume* -l 12 -r 2 -C 8 0 0

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Instead, prompt the user for missing dataset names. This
makes it more predictable and safer which datasets are read
and written, and makes it easier to use the tool.
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Jun 7, 2024
@nilsvu nilsvu requested a review from knelli2 June 18, 2024 23:04
@knelli2 knelli2 merged commit e35bd30 into sxs-collaboration:develop Jun 19, 2024
22 checks passed
@nilsvu nilsvu deleted the py_transform_vol branch June 19, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants