Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in the M1 Closure and add tests #6076

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Jun 10, 2024

Fixes:

  • Up-down tensor index agreement error
  • Assigning to entire DataVectors instead of components

Ping @pajkosmi

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Fixes:
* Up-down tensor index agreement error
* Assigning to entire DataVectors instead of components
@wthrowe
Copy link
Member Author

wthrowe commented Jun 28, 2024

@sxs-collaboration/spectre-core-devs Can someone review this? I believe it is blocking @pajkosmi (#6132 in particular).

@kidder kidder merged commit e9e6cc7 into sxs-collaboration:develop Jun 29, 2024
22 checks passed
@nilsvu nilsvu added the bugfix label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants