Add DgElement collection component and CreateElementCollection action #6083
Conversation
nilsdeppe
force-pushed
the
add_threading_17
branch
from
fedf616
to
86f0312
Compare
|
I've rebased and squashed in the couple changes. I don't know what to do about the clang-tidy errors because I think this is an issue with clang-tidy not compiling the code correctly. I can build the code fine and what clang-tidy is reporting is a compilation error. With C++17 or 20 structured bindings are variables that can be captured in lambdas, whereas prior to that there were local names and thus could not be captured. I think the issue has something to do with how clang-tidy is being used. It's either that we are using an older version or that the standard flag is not being handled correctly in the header file context. |
There was a problem hiding this comment.
According to the comments of the accepted answer here, even though the feature is supported in c++17/20, apparently clang (through major version 15) still didn't support this. And I just checked, in the container we use a clang-tidy version of 14, so that'd explain why we are getting the errors. Looks like we should update the clang-tidy version we use, but that's beyond this PR.
| auto downcast(const Parallel::DgElementArrayMemberBase<Dim>& base) | ||
| -> const dg_element_array_member& { | ||
| #ifdef SPECTRE_DEBUG | ||
| return dynamic_cast<const dg_element_array_member&>(base); |
There was a problem hiding this comment.
what is the reason for doing the cast in this manner?
There was a problem hiding this comment.
I haven't needed these (thought I would) so just removing them.
nilsdeppe
force-pushed
the
add_threading_17
branch
from
86f0312
to
1d34d52
Compare
|
I've rebased and squashed in fixes. Let me know if there's anything else! |
|
Ignoring macOS timeout and outdated clang-tidy errors |
Proposed changes
This is the last bit of code for GTS nodegroup with no functions of time. I'll submit another PR soon to add support for functions of time. I still need to finish support for LTS.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments