Add threaded callbacks for functions of times #6084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
requested changes
Jun 12, 2024
Comment on lines
+102
to
+103
| template <typename ThreadedAction, typename Proxy, typename... Args> | ||
| class ThreadedActionCallback : public Callback { |
There was a problem hiding this comment.
We have a test for these in Unit/Parallel/Test_Callback.cpp. Could you add some there? I know it's a bit more work, but just so we are guaranteed that they are working
Comment on lines
153
to
154
| /// GlobalCache which calls the threaded action passed in as a template | ||
| /// parameter. The `Args` are moved into the callback. |
There was a problem hiding this comment.
They're forwarded, not moved. There's a difference, right?
There was a problem hiding this comment.
Yep, I'll also update the simple action variant to say forwarded as well!
nilsdeppe
force-pushed
the
add_threading_18
branch
from
4ef2f79
to
13b036c
Compare
knelli2
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments