Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve some CLI errors and docs #6088

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Jun 12, 2024

Proposed changes

Fixes #6085.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from nilsdeppe June 12, 2024 20:58
nilsdeppe
nilsdeppe previously approved these changes Jun 12, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you for doing this so quickly! 🚀

@nilsvu
Copy link
Member Author

nilsvu commented Jun 12, 2024

I extended the last commit a bit further with more error message that benefit from the new RequiredChoicesError.

@nilsdeppe
Copy link
Member

Uh oh, looks like CI is now hitting a check you added :)

@nilsvu
Copy link
Member Author

nilsvu commented Jun 13, 2024

Fixed

@knelli2 knelli2 merged commit 6b9ff6a into sxs-collaboration:develop Jun 13, 2024
22 checks passed
@nilsvu nilsvu deleted the cli branch June 18, 2024 23:05
@knelli2 knelli2 added documentation cli/pybindings Command line interface & Python bindings labels Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spectre plot slice usability improvements
3 participants