Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pybind11 version, include in Py dependencies, support pathlib.Path #6090

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Jun 12, 2024

Proposed changes

Mostly to support Python's pathlib.Path in bindings. Also these commits make CI testing on Apple Silicon easier.

Upgrade instructions

Pybind11 version 2.7+ is required now. To upgrade, run pip install -r support/Python/requirements.txt in your Python environment.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pybind11 v2.7.0 actually installed in the container? We may need to pip install it

Installs pybind11 automatically alongside Python dependencies.
Needed for interoperability with pathlib.Path.
@knelli2 knelli2 merged commit da9a113 into sxs-collaboration:develop Jun 19, 2024
22 checks passed
@nilsvu nilsvu deleted the pathlib branch June 19, 2024 20:32
@nilsvu nilsvu added the build system CMake build system label Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system CMake build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants