Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally specify path to Horizons.h5 in Inspiral CLI #6112

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jun 24, 2024

Proposed changes

I realized I didn't add backwards compatibility support in #5957 for if the Horizons.h5 file didn't exist. This PR now allows you to specify the path to the Horizons.h5 file. If the file doesn't exist, the user is told to run postprocess-id on the ID to generate this file.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added the cli/pybindings Command line interface & Python bindings label Jun 24, 2024
@knelli2 knelli2 added this to the BBH Pipeline Automation milestone Jun 24, 2024
@knelli2 knelli2 requested a review from nilsvu June 24, 2024 23:00
support/Pipelines/Bbh/Inspiral.py Show resolved Hide resolved
support/Pipelines/Bbh/Inspiral.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Inspiral.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Inspiral.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Inspiral.py Outdated Show resolved Hide resolved
@nilsvu nilsvu merged commit f440a83 into sxs-collaboration:develop Jun 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants