Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial temperature lower bound from EOS #6121

Conversation

ctrandrsn
Copy link
Contributor

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@ctrandrsn ctrandrsn requested a review from nilsdeppe June 26, 2024 15:55
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple formatting suggestions/requests. Please squash immediately!

@ctrandrsn ctrandrsn force-pushed the temperature_lower_bound_SpecIntialData branch from fb187e7 to 36c826e Compare June 27, 2024 14:55
@ctrandrsn ctrandrsn force-pushed the temperature_lower_bound_SpecIntialData branch from 36c826e to 0506a8d Compare June 27, 2024 17:52
@nilsdeppe nilsdeppe merged commit d954660 into sxs-collaboration:develop Jun 28, 2024
20 of 22 checks passed
@ctrandrsn ctrandrsn deleted the temperature_lower_bound_SpecIntialData branch July 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants