Set shape of initial BBH inspiral excisions to ID excisions #6127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
changed the title
nilsvu
commented
Jun 27, 2024
support/Pipelines/Bbh/Inspiral.yaml
Outdated
| @@ -116,7 +116,7 @@ DomainCreator: | |||
| - {{ ExcisionAShapeSpin_y }} | |||
| - {{ ExcisionAShapeSpin_z }} | |||
| {% endif %} | |||
| SizeInitialValues: [0.0, 0.0, 0.0] | |||
| SizeInitialValues: [0.0, -0.1, 0.0] | |||
There was a problem hiding this comment.
@knelli2 I had to set this as well to get the control systems to start. Do you have a better idea how to do this; and do you know what SpEC does here? @markscheel do you know?
There was a problem hiding this comment.
Sometimes you have to do this in spec for high spins (make the excision surface move outward to avoid initial incoming char speeds), but I did not have to do this for the spec initial data I evolved
There was a problem hiding this comment.
I dropped this change and instead made the ID excisions bigger to match the value SpEC uses for negative-expansion boundary conditions. That seems to help.
nilsvu
force-pushed
the
fix_pipeline
branch
3 times, most recently
from
ac7e62e
to
acebe92
Compare
Helps the evolution control system to get started initially. SpEC seems to use a fraction of 0.97, but our control systems can't shrink the horizons yet (need state 3). A fraction of 0.93 seems enough to get the control systems started.
knelli2
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #6126. This makes sure that the ID can always be interpolated to the Ev grid. Leaves #6128 open to do later.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments