Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gaussian plus constant constraint gamma for ScalarTensor #6129

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

guilara
Copy link
Contributor

@guilara guilara commented Jun 27, 2024

Proposed changes

I want add the Gaussian plus constant for the constraint gammas of the CurvedScalarWave system.

(Is there a way the to avoid so much duplicate code? Some member functions of the gh classes are private so I think I cannot wrap them.)

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@guilara guilara force-pushed the PRs-ScalarTensor-ConstraintGammas branch from 6d8d061 to 54330ed Compare June 27, 2024 13:47
@guilara guilara added this to the ScalarTensor evolution milestone Jun 27, 2024
@guilara guilara force-pushed the PRs-ScalarTensor-ConstraintGammas branch 6 times, most recently from 534e48d to ef38235 Compare June 28, 2024 10:06
@guilara guilara force-pushed the PRs-ScalarTensor-ConstraintGammas branch from ef38235 to 09bfeb3 Compare July 10, 2024 13:35
@knelli2
Copy link
Contributor

knelli2 commented Aug 21, 2024

@guilara Do you want to make this into a full PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants