Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3d EOSes for Spec initial data #6134

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

ctrandrsn
Copy link
Contributor

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@ctrandrsn ctrandrsn requested a review from nilsdeppe June 28, 2024 14:31
nilsdeppe
nilsdeppe previously approved these changes Jun 28, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you, in this PR you can add a commit that modifies line 13 of src/Evolution/Systems/GrMhd/GhValenciaDivClean/AllSolutions.hpp to also have grmhd::AnalyticData::SpecInitialData<3> in it :) I think that's all that's needed to then actually read the initial data!

@kidder kidder merged commit 09e5715 into sxs-collaboration:develop Jun 29, 2024
20 of 22 checks passed
@ctrandrsn ctrandrsn deleted the 3dEosSpecID branch July 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants