Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase epsilon in MultiLinearSpanInterpolation test #6153

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Jul 15, 2024

Proposed changes

Found from this CI, increase the epsilon. First commit doesn't change the test at all, just makes formatting conform to our standards.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 requested a review from nilsdeppe July 15, 2024 23:30
nilsdeppe
nilsdeppe previously approved these changes Jul 16, 2024
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did you want to do the last few clang-tidy things? Up to you :)

for (size_t nv = 0; nv < NumVar; ++nv) {
CAPTURE(y_expected[nv]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like clang-tidy wants these using gsl::at too (or some subset of them at least)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad. Squashed those in as well.

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!! :D

@nilsdeppe nilsdeppe merged commit ce56118 into sxs-collaboration:develop Jul 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants