Add actions GetItemFromDistributedObject, SimpleActionOnElement, and PrintDgElementArray (nodegroup support) #6161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidder
requested changes
Jul 18, 2024
|
|
||
| namespace Parallel::Actions { | ||
| /*! | ||
| * \brief A local synchronous action that rreturns a pointer to the tag. |
There was a problem hiding this comment.
returns a pointer to the item specified by the tag
| * | ||
| * The action uses `db::get_mutable_reference` to avoid DataBox locking | ||
| * interference. However, this means that thread safety with respect to the | ||
| * retrieved tag must be ensure by the user. |
This allows retrieving items from a component, which is needed with the ArrayCollection code.
We'll need to think about how to do internode LB later.
nilsdeppe
force-pushed
the
add_threading_25
branch
from
d5ef0e3
to
7d56579
Compare
|
Done and squashed. Thanks! |
knelli2
approved these changes
Jul 19, 2024
kidder
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments