Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ADM integrals with a boosted Schwarzschild solution. #6177

Merged

Conversation

iago-mendes
Copy link
Member

Proposed changes

This PR tests the ADM mass and ADM linear momentum calculations with a spacetime solution that has a conformal factor different than 1.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@iago-mendes iago-mendes changed the title Test ADM integrals with a boosted Schwarchild solution. Test ADM integrals with a boosted Schwarzschild solution. Jul 25, 2024
@iago-mendes iago-mendes force-pushed the boosted-schwarzschild branch 2 times, most recently from 5867479 to f3bfbfb Compare July 29, 2024 18:27
@iago-mendes iago-mendes requested a review from nilsvu July 30, 2024 05:15
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash. Best fix the clang-tidy issues while you're at it.

@nilsvu nilsvu merged commit a67c8a6 into sxs-collaboration:develop Aug 1, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants