Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use continued fraction semiconvergent on overflow #6180

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Jul 26, 2024

The last representable convergent may not be accurate enough.

Fixes #6179

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

The last representable convergent may not be accurate enough.
@knelli2 knelli2 merged commit 90925fd into sxs-collaboration:develop Aug 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random failure of Unit.Utilities.FractionUtilities.ContinuedFraction
2 participants