Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure center of mass in XCTS system. #6192

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

iago-mendes
Copy link
Member

Proposed changes

This PR computes the center of mass as a surface integral over the domain outer boundary.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@iago-mendes iago-mendes requested a review from nilsvu August 2, 2024 07:41
Copy link
Member

@nilsvu nilsvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash everything

src/Elliptic/Systems/Xcts/Events/ObserveAdmIntegrals.cpp Outdated Show resolved Hide resolved
@nilsvu nilsvu merged commit b0937e9 into sxs-collaboration:develop Aug 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants