Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor plotting functions out of CLI #6196

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 3, 2024

So they can be used in Py scripts.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

So they can be used in Py scripts.
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Aug 3, 2024
@nilsvu nilsvu requested a review from knelli2 August 3, 2024 19:05
knelli2
knelli2 previously approved these changes Aug 3, 2024
@knelli2 knelli2 added the priority critical for progress label Aug 3, 2024
@knelli2 knelli2 enabled auto-merge August 3, 2024 19:06
@knelli2 knelli2 merged commit 153bff9 into sxs-collaboration:develop Aug 3, 2024
22 checks passed
@nilsvu nilsvu deleted the py_funcs branch October 22, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings priority critical for progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants