Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to logos #6201

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Add link to logos #6201

merged 1 commit into from
Aug 13, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 8, 2024

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

nilsdeppe
nilsdeppe previously approved these changes Aug 8, 2024
docs/Main.md Outdated Show resolved Hide resolved
docs/Main.md Outdated
Comment on lines 39 to 40

![banner](docs/Images/banner.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the word "spectre" be a bit larger? It looks a tad small in the space that it's in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ I think it's fine, it's personal preference I suppose. Try this size and adjust later if we find it's too small?

FYI, I intend to add a gravitational wave visualization to this banner when I find the time, to have the "s" radiate a burst of GWs in 3D.

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to change how this looks for dark-mode. The random white rectangle looks a bit odd. But we can do that later.

image

@knelli2 knelli2 enabled auto-merge August 13, 2024 16:32
@knelli2 knelli2 added the auto-merge GitHub's auto-merge has been enabled for this PR. label Aug 13, 2024
@knelli2 knelli2 disabled auto-merge August 13, 2024 17:37
@knelli2 knelli2 merged commit 9529b64 into sxs-collaboration:develop Aug 13, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge GitHub's auto-merge has been enabled for this PR. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants