Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlotPowerMonitors: skip filtered modes #6206

Merged
merged 1 commit into from
Aug 13, 2024
Merged

PlotPowerMonitors: skip filtered modes #6206

merged 1 commit into from
Aug 13, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 12, 2024

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Aug 12, 2024
knelli2
knelli2 approved these changes Aug 13, 2024
View reviewed changes
src/Visualization/Python/PlotPowerMonitors.py
Comment on lines 62 to 63
):
plot_over_time = obs_id is None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but we should move the doc string from the _command function to this function.

@knelli2 knelli2 merged commit 84c27de into sxs-collaboration:develop Aug 13, 2024
22 checks passed
@nilsvu nilsvu deleted the py_power_monitors branch October 22, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knelli2 knelli2 knelli2 approved these changes

Assignees
No one assigned
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsvu @knelli2