Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PCH issue #6220

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix PCH issue #6220

merged 1 commit into from
Aug 15, 2024

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 15, 2024

I got warnings from clang saying the PCH was ignored because the BlazeExceptions.hpp header appeared first as an -include. This happened after #6203. This change fixed it.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from nilsdeppe August 15, 2024 00:49
nilsdeppe
nilsdeppe previously approved these changes Aug 15, 2024
I got warnings from clang saying the PCH was ignored because the BlazeExceptions.hpp header
appeared first as an `-include`.
This change fixed it.
@nilsdeppe nilsdeppe merged commit 5c08314 into sxs-collaboration:develop Aug 15, 2024
21 of 22 checks passed
@nilsvu nilsvu deleted the fix_pch branch October 22, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants