Use PostNewtonian.jl for initial orbital parameters #6224
+122
−59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replaces the dependence on SpEC to compute low-eccentricity initial orbital parameters with the
sxs
package. It provides the PN approximations at higher PN order than SpEC, is much faster, and avoids spurious output from old Fortran code (LSODA) that was used in SpEC.The PN approximations are provided through the
PostNewtonian.jl
Julia package, so Julia will be downloaded on first use, which may take a few minutes.See also moble/PostNewtonian.jl#41, which made this possible.
Upgrade instructions
To use low-eccentricity initial orbital parameters for BBH initial data, install the
sxs
package in your Python environment:# In the build directory: ./bin/python-spectre -m pip install sxs
Now you can use
./bin/spectre bbh generate-id
with the--eccentricity=0
option.Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments