Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PostNewtonian.jl for initial orbital parameters #6224

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 15, 2024

Proposed changes

Replaces the dependence on SpEC to compute low-eccentricity initial orbital parameters with the sxs package. It provides the PN approximations at higher PN order than SpEC, is much faster, and avoids spurious output from old Fortran code (LSODA) that was used in SpEC.
The PN approximations are provided through the PostNewtonian.jl Julia package, so Julia will be downloaded on first use, which may take a few minutes.

See also moble/PostNewtonian.jl#41, which made this possible.

Upgrade instructions

To use low-eccentricity initial orbital parameters for BBH initial data, install the sxs package in your Python environment:

# In the build directory:
./bin/python-spectre -m pip install sxs

Now you can use ./bin/spectre bbh generate-id with the --eccentricity=0 option.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu force-pushed the pn_initial_orbital_params branch 6 times, most recently from 2f85cfc to 6cafeef Compare August 21, 2024 17:37
@nilsvu nilsvu force-pushed the pn_initial_orbital_params branch 3 times, most recently from a0ab56f to 14a0626 Compare August 29, 2024 08:08
Replaces the dependence on SpEC to compute low-eccentricity
initial orbital parameters with the `sxs` package.
It provides the PN approximations at higher PN order than
SpEC, is much faster, and avoids spurious output from old
Fortran code (LSODA) that was used in SpEC.
The PN approximations are provided through the
`PostNewtonian.jl` Julia package, so Julia will be downloaded
on first use, which may take a few minutes.
@knelli2 knelli2 added this to the Eccentricity Control milestone Sep 7, 2024
@knelli2 knelli2 added ci/cd Continuous integration & deployment cli/pybindings Command line interface & Python bindings labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continuous integration & deployment cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants