Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wedge Offset Option to BCO #6243

Merged

Conversation

AlexCarpenter46
Copy link
Contributor

@AlexCarpenter46 AlexCarpenter46 commented Aug 22, 2024

Proposed changes

This is 3rd PR in the chain that adds the ability to offset the wedges. This PR adds the CubeScale option to BCO domain which will offset the wedge if your CubeScale is larger than 1.0. Specifying CubeScale as 1.0 makes the cube size the initial separation between the two objects.

Upgrade instructions

Add the CubeScale option in the DomainCreator->BinaryCompactObject section like this.

DomainCreator:
  BinaryCompactObject:
    CubeScale: 1.0

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

This PR depends on #6234 and #6214

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Please add a fixup with these changes

src/Domain/Creators/BinaryCompactObject.cpp Outdated Show resolved Hide resolved
src/Domain/Creators/BinaryCompactObject.cpp Show resolved Hide resolved
src/Domain/Creators/BinaryCompactObject.cpp Outdated Show resolved Hide resolved
src/Domain/Creators/BinaryCompactObject.cpp Outdated Show resolved Hide resolved
src/Domain/Creators/BinaryCompactObject.cpp Outdated Show resolved Hide resolved
src/Domain/DomainHelpers.hpp Outdated Show resolved Hide resolved
tests/Unit/Domain/Test_DomainHelpers.cpp Outdated Show resolved Hide resolved
@knelli2 knelli2 added this to the BBH First Paper milestone Sep 5, 2024
@AlexCarpenter46 AlexCarpenter46 force-pushed the BCO_Offset_Option branch 2 times, most recently from 8bff09c to af634d2 Compare September 5, 2024 22:58
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You can squash these last couple things in all together

src/Domain/DomainHelpers.hpp Outdated Show resolved Hide resolved
src/Domain/Creators/BinaryCompactObject.cpp Outdated Show resolved Hide resolved
@AlexCarpenter46
Copy link
Contributor Author

Squashed @knelli2, thanks for the reviews :)

knelli2
knelli2 previously approved these changes Sep 6, 2024
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Squash

@knelli2 knelli2 added the priority critical for progress label Sep 6, 2024
Co-authored-by: Alexandra Macedo <alexandra.l.macedo@gmail.com>
Co-authored-by: Marceline Bonilla <marceline.bonilla@black-holes.org>
@knelli2 knelli2 merged commit c12b520 into sxs-collaboration:develop Sep 7, 2024
23 checks passed
@knelli2 knelli2 linked an issue Sep 7, 2024 that may be closed by this pull request
@knelli2 knelli2 linked an issue Sep 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority critical for progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BBH domain: translate inner spheres to increase size of cubes
4 participants