-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wedge Offset Option to BCO #6243
Add Wedge Offset Option to BCO #6243
Conversation
eb115b8
to
df0db94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Please add a fixup with these changes
tests/Unit/Domain/Creators/TimeDependentOptions/Test_BinaryCompactObject.cpp
Show resolved
Hide resolved
...s/CurvedScalarWave/Worldtube/SingletonActions/Test_InitializeElementFacesGridCoordinates.cpp
Outdated
Show resolved
Hide resolved
8bff09c
to
af634d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You can squash these last couple things in all together
af634d2
to
0a339b2
Compare
Squashed @knelli2, thanks for the reviews :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Squash
Co-authored-by: Alexandra Macedo <alexandra.l.macedo@gmail.com> Co-authored-by: Marceline Bonilla <marceline.bonilla@black-holes.org>
8e8fe3f
to
66fb37d
Compare
Proposed changes
This is 3rd PR in the chain that adds the ability to offset the wedges. This PR adds the CubeScale option to BCO domain which will offset the wedge if your CubeScale is larger than 1.0. Specifying CubeScale as 1.0 makes the cube size the initial separation between the two objects.
Upgrade instructions
Add the CubeScale option in the DomainCreator->BinaryCompactObject section like this.
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments
This PR depends on #6234 and #6214