Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop time step rejection #6250

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Aug 26, 2024

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Stopped doing anything in version 7.  New versions are starting to
complain.
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geoffrey4444 could you please try this change out on the case you found that fails? Once you approve, I'll go ahead and merge

@wthrowe
Copy link
Member Author

wthrowe commented Aug 27, 2024

Updated to not test the ASSERT when assertions are not enabled.

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geoffrey4444 Has tested this on a BBH and confirms it works

@knelli2 knelli2 merged commit 11928b9 into sxs-collaboration:develop Aug 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants