Adds worldtube functions of time to BinaryCompactObject
#6255
Conversation
| domain::creators::BinaryCompactObject<false>, | ||
| domain::creators::Brick, domain::creators::Cylinder, |
There was a problem hiding this comment.
In the BBH executable, you also need to have BCO<false> since we use a different list there
| ASSERT(not translation_map_options_.has_value(), | ||
| "Translation map is not implemented for worldtube evolutions."); |
There was a problem hiding this comment.
Make these ERRORs. If the user specifies an incorrect option, we should get an error and not be able to proceed
| tmpl::pair<DomainCreator<volume_dim>, | ||
| tmpl::list<domain::creators::BinaryCompactObject<false>>>, |
There was a problem hiding this comment.
Should this be <true>? Or are you not enabling the worldtube FoTs yet?
There was a problem hiding this comment.
I am not enabling them yet but will do so in a follow-up PR (hopefully tomorrow). Currently, the worldtube fots are not being updated, so the executable would not be usable.
| if constexpr (UseWorldtube) { | ||
| static_assert(not IsCylindrical, | ||
| "Cylindrical map not supported with worldtube"); | ||
| return create_worldtube_functions_of_time(); |
There was a problem hiding this comment.
Also (void)initial_expiration_times. Or you could optionally check that the initial expiration times are empty because there shouldn't be any control systems for the CSW system.
|
@knelli2 thanks, I included your suggestions. test failures look unrelated to me and I am not sure why clang-tidy got stuck |
|
Squashed in, thank you for your review! |
|
Ignoring unrelated test failures |
This PR allows the
BinaryCompactObjectdomain creator to return the functions of time needed by the worldtube evolution.This required either adding a Worldtube argument that could be determined in the input file at runtime or templating the class on a bool. @knelli2 and I decided it is best to use the latter approach, as a
UseWorldtubeoption in the input file might be confusing to 99 % of users who would not need it. The template parameter is defaulted tofalseand only this instantiation is added to the Factory so it should be very hard for a user to use the wrong one by accident.