Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inspiral.yaml #6259

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 30, 2024

Proposed changes

Small updates to the BBH Inspiral.yaml:

  • Switches time stepper to AdamsMoulton because it's faster.
  • Trigger AH observations more often, but not constraint energy
  • Observe fewer volume fields to save disk space

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Comment on lines 318 to 319
- PointwiseL2Norm(GaugeConstraint)
- PointwiseL2Norm(ThreeIndexConstraint)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are really useful to have. Please leave them.

Comment on lines 291 to 292
# Observe apparent horizons often enough so they find the next horizon based
# on the previous initial guess.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add that this is an issue with the AH finders not sharing initial guesses and that it needs to be fixed.

@nilsvu nilsvu merged commit ee0a588 into sxs-collaboration:develop Sep 4, 2024
23 checks passed
@nilsvu nilsvu deleted the update_inspiral branch September 4, 2024 18:25
@knelli2 knelli2 added the cli/pybindings Command line interface & Python bindings label Sep 5, 2024
@knelli2 knelli2 added this to the BBH Pipeline Automation milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants