Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe worldtube position, velocity and acceleration #6272

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Observe worldtube position, velocity and acceleration #6272

merged 1 commit into from
Sep 17, 2024

Conversation

nikwit
Copy link
Contributor

@nikwit nikwit commented Sep 5, 2024 •
edited by kidder
Loading

Upgrade instructions

knelli2
knelli2 requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash immediately

src/Evolution/Systems/CurvedScalarWave/Worldtube/SingletonActions/ObserveWorldtubeSolution.hpp Outdated Show resolved Hide resolved
@nikwit
Copy link
Contributor Author

nikwit commented Sep 16, 2024

thanks for the review, I have squashed and rebased.

@knelli2
Copy link
Contributor

knelli2 commented Sep 17, 2024

Ignoring the clang-13 KerrSchild XCTS error because it's unrelated

@knelli2 knelli2 merged commit 50d1de5 into sxs-collaboration:develop Sep 17, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knelli2 knelli2 knelli2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikwit @knelli2