Add serial numeric initial data loading #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
changed the title
nilsvu
changed the title
nilsvu
changed the title
nilsdeppe
requested changes
Sep 11, 2024
| * classes for the executable. | ||
| * - The data is interpolated and returned in serial, just like analytic data. | ||
| * - The data can be re-interpolated to any set of points on request, which is | ||
| * an easy way to handle AMR or domain other changes. |
There was a problem hiding this comment.
domain other changes -> other domain changes
The 'GCC diagnostic' in src/IO/Exporter/Exporter.cpp is not respected by gcc < 13, so we have to disable the warning. Upstream bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53431
nilsdeppe
approved these changes
Sep 13, 2024
|
This is the PR that I asked about the XCTS KS failure test about. Please feel free to merge when you think it's ready, @nilsvu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds a
NumericDataclass that can be used in place of analytic data. It just loads the requested tags from numeric volume data files, just like the SpEC or FUKA initial data classes. It's an easy alternative to the parallel numeric data reader. See the docs in this PR for advantages and caveats.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments