-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add executable to write CCE worldtube coords to a file #6284
Add executable to write CCE worldtube coords to a file #6284
Conversation
src/Executables/WriteCceWorldtubeCoordsToFile/WriteCceWorldtubeCoordsToFile.cpp
Show resolved
Hide resolved
ee747f9
to
83a5f1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this! LGTM, just a couple small suggestions. Please squash right away :)
void write_strahlkorper_coords_to_text_file( | ||
const Strahlkorper<Frame>& strahlkorper, | ||
const std::string& output_file_name, AngularOrdering ordering, | ||
bool overwrite = false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional] name this overwrite_file
to be explicit?
src/NumericalAlgorithms/SphericalHarmonics/IO/StrahlkorperCoordsToTextFile.hpp
Show resolved
Hide resolved
src/Executables/WriteCceWorldtubeCoordsToFile/WriteCceWorldtubeCoordsToFile.cpp
Show resolved
Hide resolved
83a5f1c
to
49a39c5
Compare
@nilsdeppe Squashed, thanks! |
Proposed changes
Part of #6246. A C++ executable was explicitly chosen for this even though it is very simple so it can be compiled and distributed like our other CCE executables. A python version would have to have some kind of PyBindings packaged in and that didn't seem like the best approach.
I added a function that does this, bound it in python just in case we want to use it, and then made the executable.
I currently don't add this to the tarball that we create at each release because there is still work that needs to be done in the CCE executable and the ReduceCceWorldtube executable. Once that is done, then I will add this executable.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments