Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executable to write CCE worldtube coords to a file #6284

Merged

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Sep 12, 2024

Proposed changes

Part of #6246. A C++ executable was explicitly chosen for this even though it is very simple so it can be compiled and distributed like our other CCE executables. A python version would have to have some kind of PyBindings packaged in and that didn't seem like the best approach.

I added a function that does this, bound it in python just in case we want to use it, and then made the executable.

I currently don't add this to the tarball that we create at each release because there is still work that needs to be done in the CCE executable and the ReduceCceWorldtube executable. Once that is done, then I will add this executable.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 mentioned this pull request Sep 12, 2024
13 tasks
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! LGTM, just a couple small suggestions. Please squash right away :)

void write_strahlkorper_coords_to_text_file(
const Strahlkorper<Frame>& strahlkorper,
const std::string& output_file_name, AngularOrdering ordering,
bool overwrite = false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] name this overwrite_file to be explicit?

@knelli2
Copy link
Contributor Author

knelli2 commented Sep 12, 2024

@nilsdeppe Squashed, thanks!

@nilsdeppe nilsdeppe merged commit 83de4b9 into sxs-collaboration:develop Sep 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants