Fixes for nodegroups running on multiple nodes #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
reviewed
Sep 12, 2024
Comment on lines
-27
to
+28
| auto my_proxy = Parallel::get_parallel_component<ParallelComponent>(cache); | ||
| auto my_proxy = Parallel::get_parallel_component<ParallelComponent>( | ||
| cache)[Parallel::my_node<size_t>(cache)]; |
There was a problem hiding this comment.
Just for my understanding, this used to do a broadcast to the whole collection for every element on this node? But that didn't matter because you only ran on a single node? And now you only send the messages to the local node?
There was a problem hiding this comment.
Right, and the issue was that it would try to run an element that wasn't on its node and would then fail with "I can't find this element!"
There was a problem hiding this comment.
Thanks for the explanation!
nilsdeppe
force-pushed
the
add_threading_29
branch
from
d1f1f13
to
d756f61
Compare
|
I squashed the move of |
knelli2
approved these changes
Sep 13, 2024
Comment on lines
-27
to
+28
| auto my_proxy = Parallel::get_parallel_component<ParallelComponent>(cache); | ||
| auto my_proxy = Parallel::get_parallel_component<ParallelComponent>( | ||
| cache)[Parallel::my_node<size_t>(cache)]; |
There was a problem hiding this comment.
Thanks for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There's still some issue I need to resolve, but these were the easy ones to find.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments