Communicate volume mesh in boundary data #6293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nilsdeppe please test this for a BNS |
nilsdeppe
requested changes
Sep 17, 2024
| @@ -177,12 +178,12 @@ struct BoundaryCorrectionAndGhostCellsInbox { | |||
| ReceiveDataType&& data) { | |||
| auto& current_inbox = (*inbox)[time_step_id]; | |||
| if (auto it = current_inbox.find(data.first); it != current_inbox.end()) { | |||
| auto& [volume_mesh_of_ghost_cell_data, face_mesh, ghost_cell_data, | |||
There was a problem hiding this comment.
Please also update retrieve_boundary_data_spsc in src/Evolution/DiscontinuousGalerkin/Actions/ApplyBoundaryCorrections.hpp
|
This tag will be used to hold the mesh used for communicating subcell ghost data instead of using the tag NeighborMesh.
Also change volume_mesh_ghost_cell_data to std::optional. Now the item for Tags::NeighborMesh is always filled with the communicated volume_mesh which is the active mesh of the neighbor. The item for Tags::MeshForGhostData is set to the communicated volume_mesh_ghost_cell_data, and is only used when doing DG-subcell.
kidder
force-pushed
the
volume_mesh_in_boundary_data
branch
from
dcaeab3
to
3c7db88
Compare
nilsdeppe
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
evolution::dg::subcell::Tags::MeshForGhostDatawhich holds the volume mesh used by each neighbor for communicating subcell ghost data. This information was previously held bydomain::Tags::NeighborMesh<Dim>which will now always hold the mesh of the neighbor.BoundaryData. This is needed for reactive adaptive mesh refinement.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments