Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Metric worldtube format in CCE #6299

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Sep 20, 2024

Proposed changes

We will be making it so that the CCE executable can only read Bondi modal data. In order to get your data into that format, all transitional functionality is moving to the ReduceCceWorldtube executable.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Not sure if this was the best place for it, but there's already a warning in this option tag so I figured it'd be the best place and wouldn't be printed many times.

@nilsdeppe nilsdeppe merged commit 1b1a29f into sxs-collaboration:develop Sep 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants