Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitchhiker’s Guide Update #6304

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

SunPeike
Copy link
Contributor

@SunPeike SunPeike commented Sep 24, 2024

Updated the Hitchhiker’s Guide for SpECTRE.
Added necessary steps for using ParaView from clusters

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! It's greatly appreciated when people take the time to update our tutorials :)

Couple overall things:

  • Both in our code and in our docs, we limit the length of a line to 80 characters. Please split the lines you added to adhere to this.
  • You can squash these changes into your original changes, and remove the merge commits on your branch. If you're not sure how to do this, we can go over how to do it on Slack.

docs/Tutorials/BeginnersTutorial.md Outdated Show resolved Hide resolved
docs/Tutorials/BeginnersTutorial.md Outdated Show resolved Hide resolved
@knelli2
Copy link
Contributor

knelli2 commented Sep 27, 2024

@SunPeike Could you update the PR description? You don't say anything about Paraview 5.11.1 anymore.

@knelli2
Copy link
Contributor

knelli2 commented Sep 27, 2024

Ignoring unrelated errors

@knelli2 knelli2 merged commit 09c54cc into sxs-collaboration:develop Sep 27, 2024
21 of 23 checks passed
Copy link

@SunPeike looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:

  1. Edit the Metadata.yaml file in the repository.
  2. Add an entry to the list in Authors.Contributors with your name, affiliation, etc. Note that the list is ordered alphabetically by last name.
  3. Commit the change on a new branch and open a pull request with the change.

Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants