Allow observing only some blocks in ObserveFields #6305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidder
approved these changes
Sep 27, 2024
| @@ -157,9 +158,19 @@ class ObserveFields<VolumeDim, tmpl::list<Tensors...>, | |||
| using type = FloatingPointType; | |||
| }; | |||
|
|
|||
| /// \brief A list of block or group names on which to observe. | |||
| /// | |||
| /// Set to `All` to observer everywhere. | |||
nilsdeppe
force-pushed
the
bns_improvements_1
branch
from
4cb9b91
to
21209bd
Compare
|
Done and rebased. Thanks for the review! |
kidder
previously approved these changes
Sep 27, 2024
nilsdeppe
force-pushed
the
bns_improvements_1
branch
from
21209bd
to
4812c53
Compare
|
Sorry, had to fix a silent conflict with include file names. |
kidder
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is useful for visualizations, e.g. in a BNS simulation we only care about the stars, not the matter in the wave zone.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments