Remove zeros after LtsCoefficients arithmetic #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
previously approved these changes
Sep 30, 2024
| { | ||
| auto write = a.begin(); | ||
| for (const auto& entry : a) { | ||
| if (get<2>(entry) != 0.0) { |
There was a problem hiding this comment.
Is there any reason to think that these numbers might be approximately zero to the level we don't care about?
There was a problem hiding this comment.
You're right, these aren't exact. This should have a roundoff check of some sort.
wthrowe
added
the
in progress
wthrowe
removed
the
in progress
|
fixup LGTM. Please squash. I should've said you can squash directly on this :) |
Avoids multiplying large objects by zero later.
Already worked, but not obviously from the implementation.
|
I almost did, but decided since the change I made was nowhere near the PR comment it was better to make it obvious. |
nilsdeppe
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove zeros after LtsCoefficients arithmetic. These are the coefficients in a linear combination of Variables objects, so avoiding terms with zero coefficients is a worthwhile minor optimization.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments