Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonic HPC #6311

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add Sonic HPC #6311

merged 1 commit into from
Oct 1, 2024

Conversation

vaishakp
Copy link
Contributor

Proposed changes

Adds the Sonic HPC at ICTS-TIFR

Upgrade instructions

Code review checklist

  • [ x] The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • [ x] The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • [ x] The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@vaishakp vaishakp marked this pull request as ready for review September 26, 2024 13:30
@knelli2 knelli2 added the clusters Super computer support (env, submit, machine files) label Sep 26, 2024
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add Sonic to the docs/Installation/InstallationOnClusters.md page with any notes/tips that would be helpful for specifically running on Sonic.

I have no way to test this, so I'll take your word that it works.

support/Environments/sonic.sh Outdated Show resolved Hide resolved
support/Environments/sonic.sh Outdated Show resolved Hide resolved
support/Environments/sonic.sh Outdated Show resolved Hide resolved
support/Machines/Sonic.yaml Outdated Show resolved Hide resolved
@vaishakp vaishakp force-pushed the add_sonic_hpc branch 3 times, most recently from ef8b2b4 to 5ee9484 Compare September 27, 2024 09:18
@vaishakp
Copy link
Contributor Author

I should also add that Sonic is a very small HPC at ICTS-TIFR, and we would be a few people using it, atleast for now.

@vaishakp
Copy link
Contributor Author

vaishakp commented Sep 27, 2024

Please also add Sonic to the docs/Installation/InstallationOnClusters.md page with any notes/tips that would be helpful for specifically running on Sonic.

I have no way to test this, so I'll take your word that it works.

This is currently being also tested by one of my colleagues at ICTS

@vaishakp vaishakp force-pushed the add_sonic_hpc branch 2 times, most recently from 1d02898 to 5c7663c Compare September 27, 2024 13:16
support/Environments/sonic.sh Outdated Show resolved Hide resolved
docs/Installation/InstallationOnClusters.md Outdated Show resolved Hide resolved
docs/Installation/InstallationOnClusters.md Outdated Show resolved Hide resolved
docs/Installation/InstallationOnClusters.md Outdated Show resolved Hide resolved
docs/Installation/InstallationOnClusters.md Outdated Show resolved Hide resolved
@vaishakp vaishakp marked this pull request as draft September 29, 2024 07:29
@vaishakp vaishakp force-pushed the add_sonic_hpc branch 3 times, most recently from 3801944 to 775c834 Compare October 1, 2024 06:50
@vaishakp vaishakp marked this pull request as ready for review October 1, 2024 10:34
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding this

@knelli2 knelli2 merged commit aa6422a into sxs-collaboration:develop Oct 1, 2024
23 checks passed
Copy link

github-actions bot commented Oct 1, 2024

@vaishakp looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:

  1. Edit the Metadata.yaml file in the repository.
  2. Add an entry to the list in Authors.Contributors with your name, affiliation, etc. Note that the list is ordered alphabetically by last name.
  3. Commit the change on a new branch and open a pull request with the change.

Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clusters Super computer support (env, submit, machine files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants