Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BBH ID control of CoM and Padm. #6315

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

iago-mendes
Copy link
Member

Proposed changes

With recent changes to the calculation of the center of mass and linear momentum integrals, we are now ready to enable their control by default. We also take this opportunity to set the control residual tolerance to 1.e-4 instead of 1.e-6, which makes more sense given that junk radiation effects are on the order of 1.e-3.

For an equal-mass non-spinning case with default settings, the control loop currently reaches the residual tolerance in just 3 iterations. In human time, this takes ~17 minutes on 1 node of CaltechHPC.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@@ -15,7 +15,7 @@

logger = logging.getLogger(__name__)

DEFAULT_RESIDUAL_TOLERANCE = 1.0e-6
DEFAULT_RESIDUAL_TOLERANCE = 1.0e-4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here that this should be just below junk radiation effects on the controlled parameters

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@nilsvu nilsvu merged commit 387d143 into sxs-collaboration:develop Sep 30, 2024
23 checks passed
@iago-mendes iago-mendes deleted the enable-control branch September 30, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants