Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transition to Ringdown Script #6316

Merged

Conversation

AlexCarpenter46
Copy link
Contributor

@AlexCarpenter46 AlexCarpenter46 commented Sep 30, 2024

Proposed changes

This is the first iteration of the transition to ringdown script for the BBH's. To use this script, you have to have a BBH that has reached common horizon and output reduction and volume data at the time of common horizon finds using the pipeline, then you can do something like

spectre bbh start-ringdown path/to/final/segment/directory/from/inspiral --path-to-output-h5 Ringdown_Coefs.h5 --match-time 5000 --number-of-steps 10 --settling-timescale 10.0 -L 2 -P 9 -O Ringdown_9 --no-submit

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

This script is still very experimental, if you try it out and things don't work or break, please let me know :)

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add fixups for each commit since this is a pretty long PR

src/Evolution/Ringdown/CMakeLists.txt Show resolved Hide resolved
src/Evolution/Ringdown/Python/Bindings.cpp Outdated Show resolved Hide resolved
src/Evolution/Ringdown/Python/Bindings.cpp Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
Comment on lines +64 to +65
# and has not been tested for other configurations.
SizeInitialValues: [0.0, -1.0, 0.0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave this for now, but ideally in the future I think we'll want to get rid of this

src/Evolution/Ringdown/Python/FunctionsOfTimeFromVolume.py Outdated Show resolved Hide resolved
support/Pipelines/Bbh/Ringdown.py Outdated Show resolved Hide resolved
knelli2
knelli2 previously approved these changes Oct 23, 2024
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Squash

@knelli2 knelli2 merged commit 87b6a1d into sxs-collaboration:develop Oct 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants