-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Transition to Ringdown Script #6316
Add Transition to Ringdown Script #6316
Conversation
f90561b
to
3a0bdf8
Compare
dbadc38
to
a2ad697
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add fixups for each commit since this is a pretty long PR
src/Evolution/Ringdown/StrahlkorperCoefsInRingdownDistortedFrame.cpp
Outdated
Show resolved
Hide resolved
# and has not been tested for other configurations. | ||
SizeInitialValues: [0.0, -1.0, 0.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave this for now, but ideally in the future I think we'll want to get rid of this
71c5285
to
f499cfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Squash
f499cfe
to
4df653c
Compare
4df653c
to
f772457
Compare
Proposed changes
This is the first iteration of the transition to ringdown script for the BBH's. To use this script, you have to have a BBH that has reached common horizon and output reduction and volume data at the time of common horizon finds using the pipeline, then you can do something like
spectre bbh start-ringdown path/to/final/segment/directory/from/inspiral --path-to-output-h5 Ringdown_Coefs.h5 --match-time 5000 --number-of-steps 10 --settling-timescale 10.0 -L 2 -P 9 -O Ringdown_9 --no-submit
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments
This script is still very experimental, if you try it out and things don't work or break, please let me know :)