Enable p-refinement via an Event #6320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wthrowe
requested changes
Oct 2, 2024
| @@ -20,6 +20,7 @@ namespace evolution::dg { | |||
| * 1. the volume mesh of the element. | |||
| * 2. the volume mesh corresponding to the ghost cell data. This allows eliding | |||
| * projection when all neighboring elements are doing DG. | |||
| * 3. the mortar mesh of the data on the mortar | |||
| * 3. the mesh of the neighboring element's face (not the mortar mesh!) | |||
There was a problem hiding this comment.
Renumber the later entries. (The numbering being wrong actually confuses doxygen, which surprises me.)
| @@ -44,6 +44,7 @@ namespace evolution::dg::Tags { | |||
| * 1. the volume mesh of the element. | |||
| * 2. the volume mesh corresponding to the ghost cell data. This allows eliding | |||
| * projection when all neighboring elements are doing DG. | |||
| * 3. the mortar mesh of the data on the mortar | |||
| * 3. the mesh of the neighboring element's face (not the mortar mesh!) | |||
| face_mesh2.basis(i) == Spectral::Basis::Legendre, | ||
| "Only Legendre basis meshes are supported for element faces so far, " | ||
| "but " | ||
| "face_mesh1 is " |
|
|
||
| /// \ingroup AmrGroup | ||
| namespace amr { | ||
| /// \brief %Eventss for adaptive mesh refinement |
| boundary_data_history->at(mortar_id).local().for_each( | ||
| project_boundary_mortar_data); | ||
| boundary_data_history->at(mortar_id).remote().for_each( | ||
| project_boundary_mortar_data); |
There was a problem hiding this comment.
Call boundary_data_history->at(mortar_id).clear_coupling_cache().
| if (mortar_mesh != | ||
| received_mortar_data->second.boundary_correction_mesh) { | ||
| boundary_data_history->at(mortar_id).remote().for_each( | ||
| project_boundary_mortar_data); |
There was a problem hiding this comment.
Again, clear the cache, unless this is only modifying the entry that was just inserted, in which case add a comment that you don't have to clear the cache.
| << "\n mortar_mesh: " << mortar_mesh << "\n"); | ||
| ASSERT(local_data_on_mortar.number_of_grid_points() == | ||
| neighbor_data_on_mortar.number_of_grid_points(), | ||
| "RIP\n"); |
There was a problem hiding this comment.
Better message? Probably print out the values.
| /// \brief %Eventss for adaptive mesh refinement | ||
| namespace Events {} | ||
| } // namespace amr | ||
| namespace amr::Events {} // namespace amr::Events |
There was a problem hiding this comment.
Move reformatting to the commit where it was added. Also remove the same-line closing comment.
| {flux_data}, | ||
| {neighbor_next_time_step_id}, | ||
| decision}; | ||
| const evolution::dg::BoundaryData<Dim> data{mesh, |
nilsdeppe
requested changes
Oct 2, 2024
src/NumericalAlgorithms/DiscontinuousGalerkin/MortarHelpers.cpp
Outdated
Show resolved
Hide resolved
src/Evolution/DiscontinuousGalerkin/Actions/ApplyBoundaryCorrections.hpp
Outdated
Show resolved
Hide resolved
knelli2
reviewed
Oct 2, 2024
Comment on lines
96
to
+97
| const std::unordered_map<ElementId<Dim>, amr::Info<Dim>>& neighbor_info, | ||
| const ::dg::MortarMap<Dim, Mesh<Dim>>& neighbor_mesh, |
There was a problem hiding this comment.
Should these changes go in a different commit?
nilsdeppe
previously approved these changes
Oct 5, 2024
|
Still missing the LTS cache management. Have you tested this in an LTS evolution? |
This was missed in PR 6157.
This is the mesh corresponding to boundary_correction_data. It needs to be communicated in case the mortar needs to be reprojected after AMR increases resolution.
This is what will be used by reactive p-refinement for DG.
In order to reactively adapt to p-refinement done as an Event, the mortar data may need to be projected to a new mortar mesh.
This is the appropriate slice (which can be obtained from the mortar_id) of the volume_mesh
kidder
force-pushed
the
reactive_p_refinement
branch
from
409b2c3
to
15f71c7
Compare
wthrowe
approved these changes
Oct 16, 2024
|
We discussed some methods of testing this elsewhere. I assume you've done some of those? |
|
Discussed elsewhere. The tests have been done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR will allow p-refinement to be done as an Event.
This requires the DG scheme to reactively check if the communicated mortar data is on the correct Mesh.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments