Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some dependency tracking #6321

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix some dependency tracking #6321

wants to merge 4 commits into from
+55 −7

Conversation

nilsdeppe
Copy link
Member

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsdeppe nilsdeppe added the small Only changes a few lines of code, does a rename or is otherwise quick to review label Oct 2, 2024
knelli2
knelli2 requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can squash directly

cmake/SpectreAddInterfaceLibraryHeaders.cmake Outdated
Comment on lines 55 to 56

# Get already added headers and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expand this commend a bit more? This is quite the list of operations being done

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, yea, agreed. I just pushed an update (squashed) that attempts to explain what this is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knelli2 knelli2 knelli2 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsdeppe @knelli2