-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: suppress warnings for different name representations of the same file in the case-insensitive file system when renaming #1185
Conversation
There's an unexpected behavior: when i rename a file to it's hardlink, it will overwrite (same as being deleted) without asking. reproduce:
|
I think new commit have resolved this issue, but in a slight dumb approach. |
…i into fix-rename-case-insensitive
Thanks for the PR, I'll take care of the follow-up work on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Original issue here: #1171
Fixes #1171
This PR introduced a function
are_paths_equal
infns.rs
to determine if two paths points to the same node.It fixes the rename and bulk_rename functions not working properly when only change the case of letters.
Previously these functions only check if the new path already exists, but not considering the old and new path could be the same node in case-insensitive systems like macOS and Windows.