Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: start with multiple tabs with different paths #1443

Merged
merged 2 commits into from
Aug 10, 2024
Merged

feat: start with multiple tabs with different paths #1443

merged 2 commits into from
Aug 10, 2024

Conversation

coolkiid
Copy link
Contributor

@coolkiid coolkiid commented Aug 8, 2024 •
edited by sxyazi
Loading

  1. CLI can receive more than one paths as entries now.
  2. Modify BOOT in yazi-boot/ and Tabs in yazi-core to fit the change above.
  3. Add a test for parse_entries().

Closes #1322

For example, to open multi tabs at once, run yazi ~/Projects ~/Downloads ~/Documents.

@coolkiid coolkiid force-pushed the p/coolkiid/implement-multi-entries branch from dcf9753 to e650a78 Compare August 8, 2024 15:20
@coolkiid coolkiid changed the title feat: implement open multi tabs at once feat: implement opening multi tabs at once Aug 8, 2024
sxyazi
sxyazi reviewed Aug 10, 2024
View reviewed changes
yazi-boot/src/args.rs Outdated Show resolved Hide resolved
@coolkiid coolkiid force-pushed the p/coolkiid/implement-multi-entries branch from e650a78 to 6de5817 Compare August 10, 2024 07:06
@coolkiid coolkiid force-pushed the p/coolkiid/implement-multi-entries branch from 6de5817 to d95b851 Compare August 10, 2024 07:45
coolkiid and others added 2 commits August 10, 2024 20:32
@coolkiid @sxyazi
feat: implement opening multi tabs at once
cf5d9d2 
1. CLI can receive more than one paths as entries now.
2. Modify Boot in yazi-boot/ and Tabs in yazi-core to
fit the change above.
3. Add a test for parse_entries().

issue: sxyazi#1322
@sxyazi
Rebase
d3d9cf6
@sxyazi sxyazi force-pushed the p/coolkiid/implement-multi-entries branch from d95b851 to d3d9cf6 Compare August 10, 2024 12:32
@sxyazi sxyazi changed the title feat: implement opening multi tabs at once feat: start with multiple tabs with different paths Aug 10, 2024
sxyazi
sxyazi approved these changes Aug 10, 2024
View reviewed changes
Copy link
Owner

@sxyazi sxyazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for contributing this feature!

@sxyazi sxyazi merged commit dac72eb into sxyazi:main Aug 10, 2024
6 checks passed
@mikavilpas mikavilpas mentioned this pull request Aug 11, 2024
Closed
@Xerxes-2 Xerxes-2 mentioned this pull request Aug 15, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sxyazi sxyazi sxyazi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start with multiple tabs with different paths
2 participants
@coolkiid @sxyazi