Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XDG spec for goto navigation. #1879

Closed
wants to merge 1 commit into from

Conversation

voronind-com
Copy link

@voronind-com voronind-com commented Nov 2, 2024

Closes #1878
More info about XDG here.

@sxyazi
Copy link
Owner

sxyazi commented Nov 2, 2024

Sorry, I'm afraid I can't accept the PR, because this breaks on macOS and Windows, they don't have an XDG_CONFIG_HOME and XDG_DOWNLOAD_DIR at all, but they generally have the ~/.config and ~/Downloads folder

@sxyazi sxyazi closed this Nov 2, 2024
@sxyazi sxyazi mentioned this pull request Nov 2, 2024
3 tasks
@voronind-com
Copy link
Author

voronind-com commented Nov 2, 2024

Sorry, I'm afraid I can't accept the PR, because this breaks on macOS and Windows, they don't have an XDG_CONFIG_HOME and XDG_DOWNLOAD_DIR at all, but they generally have the ~/.config and ~/Downloads folder

Maybe OS detection would help in such cases? Right now it feels sad to lose one platform compatibility for other platforms. Same goes for manpages....

Right now yazi attempts to support all platforms w/o platform-specific features.

@voronind-com voronind-com deleted the patch-1 branch November 2, 2024 06:31
@sxyazi
Copy link
Owner

sxyazi commented Nov 2, 2024

Don't get me wrong - I can accept platform-specific features as long as they don't cause trouble for users on other platforms, and there needs to be a better way to implement it than this PR, maybe as a built-in plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use XDG paths for Goto.
2 participants