fix: avoiding duplicate candidates in the which component

[mikavilpas]

Fixes #955

Also added a test for this bug as a suggestion.

Let me know how you would prefer testing to be done in this project!

[sxyazi]

Thanks for the PR!

I don't think this test is necessary because KEYMAP.init can only be called once, and it's difficult to assume whether it will appear in other tests.

It contains unsafe code, so currently, it's restricted to only being used in the init method of each crate (like this

yazi/yazi-adaptor/src/lib.rs

Line 33 in 3a09155

pub fn init() {

) and I don't want to spread unsafe code into tests, so could you remove the test and only modify the minimum code?

[mikavilpas]

I think that makes sense. I actually noticed there were issues trying to add another test, probably because the RoCell was already allocated, making for weird errors 😄

The test has now been removed.

[SolitudeSF]

not familiar with the codebase. is it getting deduplicated each time it displays command suggestions?

[mikavilpas]

Yes, duplicates are removed every time.

@sxyazi I just noticed this doesn't yet preserve the order of the suggestions, so the suggestions can appear in a random order now. I'll fix this soon.

[mikavilpas]

Ok, order is now preserved 🙂

[sxyazi]

Thanks!

[mikavilpas]

I like your refactoring, nicely done 👍🏻