Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent binding from panicking when not in wasm #278

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Prevent binding from panicking when not in wasm #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b7d707
Prevent binding from panicking when not in wasm
Oct 14, 2021
24e9e87
Fix cfg attributes
Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/sycamore-macro/src/template/attributes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ impl ToTokens for Attribute {
tokens.extend(quote_spanned! { expr_span=> {
let signal: ::sycamore::reactive::Signal<#value_ty> = #expr;

#[cfg(target_arch = "wasm32")]
::sycamore::reactive::create_effect({
let signal = ::std::clone::Clone::clone(&signal);
let __el = ::std::clone::Clone::clone(&__el);
Expand Down
12 changes: 12 additions & 0 deletions packages/sycamore/tests/ssr/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,3 +98,15 @@ fn indexed() {
let actual = sycamore::render_to_string(|| node.clone());
assert_eq!(actual, "<ul><li>2</li><li>3</li></ul>");
}

#[test]
fn bind() {
let signal = Signal::new(String::new());

let node = template! {
input(bind:value=signal)
};

let actual = sycamore::render_to_string(|| node);
assert_eq!(actual, "<input/>");
}