Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the derive macro helper attribute builder to prop #504

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Rename the derive macro helper attribute builder to prop #504

merged 2 commits into from
Oct 16, 2022

Conversation

alexisfontaine
Copy link
Contributor

@alexisfontaine alexisfontaine commented Oct 14, 2022

Closes #497

@alexisfontaine alexisfontaine deleted the chore/rename-derive-macro-attribute branch October 14, 2022 21:19
@alexisfontaine alexisfontaine restored the chore/rename-derive-macro-attribute branch October 14, 2022 21:20
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 64.65% // Head: 64.65% // No change to project coverage 👍

Coverage data is based on head (6cf0698) compared to base (8870559).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   64.65%   64.65%           
=======================================
  Files          52       52           
  Lines        8525     8525           
=======================================
  Hits         5512     5512           
  Misses       3013     3013           
Impacted Files Coverage Δ
docs/src/main.rs 0.45% <0.00%> (ø)
packages/sycamore-macro/src/lib.rs 86.20% <ø> (ø)
packages/sycamore-router/src/router.rs 27.88% <ø> (ø)
packages/sycamore/src/suspense.rs 94.57% <ø> (ø)
website/src/content.rs 0.00% <ø> (ø)
packages/sycamore-macro/src/props.rs 72.09% <50.00%> (ø)
packages/sycamore-macro/src/component/mod.rs 96.42% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@lukechu10 lukechu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@lukechu10 lukechu10 merged commit f6331a1 into sycamore-rs:master Oct 16, 2022
@alexisfontaine alexisfontaine deleted the chore/rename-derive-macro-attribute branch October 17, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename inner attribute builder to prop
2 participants